Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slow typing in basic form #2030

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Fix slow typing in basic form #2030

merged 1 commit into from
Sep 15, 2020

Conversation

andresmgot
Copy link
Contributor

Description of the change

Calling handleBasicFormParamChange is expensive. This PR makes sure that it's only called when the user stop typing so the form is fluent.

Applicable issues

@andresmgot andresmgot merged commit 6ddd24c into master Sep 15, 2020
@andresmgot andresmgot deleted the formLag branch November 26, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absoludity absoludity absoludity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresmgot @absoludity