1942 app repos use cluster #1997
Conversation
| const { | ||
| clusters: { currentCluster }, | ||
| } = getState(); |
There was a problem hiding this comment.
why don't we do do this rather than passing around cluster all the time in other actions? 😅
There was a problem hiding this comment.
Not sure if it was asked in jest or seriousness :) . In the long run, functional code is much easier to work with, test, maintain etc., but I took a short-cut here that I didn't take with the normal components because it's not clear to me whether we'll be keeping the service catalog / service instances in the future.
There was a problem hiding this comment.
well, it was a serious question. I don't think this is a shortcut since at the end is the same than what we are doing (getting the current cluster from the state). unless I'm missing something. IMO, sacrifice a bit of complexity for the tests vs adding the parameter "cluster" or "namespace" all over the place is something reasonable. Anyway, this is just me thinking out loud.
Description of the change
Updates shared helpers for AppRepositories, ServiceBrokers and ServiceInstances to no longer rely on the non-cluster-aware backend URIs.
Benefits
Required for #1995 to be able to pass CI.
Applicable issues
Ref: #1942