Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categories filter #1961

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Categories filter #1961

merged 2 commits into from
Aug 25, 2020

Conversation

andresmgot
Copy link
Contributor

Description of the change

Extend the Chart model in the backend to include the category of the chart and apply required changes in the dashboard to use those:

Screenshot from 2020-08-24 16-01-27

Note that chart and operator categories are used.

Applicable issues

Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Are there any migration issues we need to worry about here?

@andresmgot
Copy link
Contributor Author

andresmgot commented Aug 25, 2020

Great. Are there any migration issues we need to worry about here?

Nope (as far as I can see), if a chart doesn't have annotations or the "category" key is empty, the assetsvc will return category: "" anyway, which is resolved as "Unkown" in the catalog.

@andresmgot andresmgot merged commit 406869c into master Aug 25, 2020
alexandredantas pushed a commit to alexandredantas/kubeapps that referenced this pull request Aug 26, 2020
@andresmgot andresmgot deleted the categoriesFilter branch September 8, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to filter by Chart Categories
2 participants