Update api server urls to use url helper. #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow on from #1843, where Andres' review mentioned that the namespace url should be using our url helper. While there, I've grouped all the existing helpers which hit the api server directly under `api.k8s` as well as a few more, so that we can clearly identify (and potentially remove) where the dashboard assumes direct access to the k8s api.
Also move assumption of "default" cluster from the Secret helper to call-sites (which already assume the default cluster).
andresmgot
approved these changes
Jul 21, 2020
|
|
||
| export default class Secret { | ||
| public static async create( |
There was a problem hiding this comment.
has this function gone somewhere else?
There was a problem hiding this comment.
ah, I see, this is not needed because the secrets are now being created in the backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #1843, where Andres' review mentioned that the namespace
url should be using our url helper. While there, I've grouped all the
existing helpers which hit the api server directly under
api.k8saswell as a few more, so that we can clearly identify (and
potentially remove - see #1686) where the dashboard assumes direct access to the k8s
api.
It also updates the shared Secrets helper to be cluster aware (though the call-sites for app repository functionality are not, and will-not be for now).
Ref #1762