disable use of cgo only for the ci builds #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prydonius
reviewed
Mar 13, 2018
Makefile
Outdated
| @@ -12,7 +13,7 @@ EMBEDDED_STATIC = generated/statik/statik.go | |||
| default: kubeapps | |||
|
|
|||
| kubeapps: $(EMBEDDED_STATIC) | |||
| CGO_ENABLED=0 $(GO) build -i -o $(BINARY) $(GO_FLAGS) $(IMPORT_PATH) | |||
| CGO_ENABLED=$(CGO_ENABLED) $(GO) build -i -o $(BINARY) $(GO_FLAGS) $(IMPORT_PATH) | |||
There was a problem hiding this comment.
is this needed? wouldn't it already be in the env?
There was a problem hiding this comment.
it does not exist in the env in the default case.
There was a problem hiding this comment.
right, but the default is CGO_ENABLED=1 right? if you ran go build without the env var, it shouldn't try to install anything?
There was a problem hiding this comment.
from https://golang.org/cmd/cgo/
The cgo tool is enabled by default for native builds on systems where it is expected to work. It is disabled by default when cross-compiling.
So yes, I believe we can remove it like you pointed out.
from https://golang.org/cmd/cgo/ > The cgo tool is enabled by default for native builds on systems where > it is expected to work. It is disabled by default when > cross-compiling.
prydonius
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you set
CGO_ENABLED=0, the go tool has to rebuild all the standard lib packages at$GOROOT.GOROOTmay be a system path on the developer host and thus would require dev's to executemakeas aprivileged user.
This PR re-enables the use of cgo by default, while disabling it in CI builds