Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jjo] use statik for embedded manifests #12

Merged

Conversation

jjo
Copy link
Contributor

@jjo jjo commented Nov 3, 2017

  • move embedded manifests to static/
  • adapt Makefile to make binary depend on generated/statik/statik.go
  • update vendor deps

@jjo
Copy link
Contributor Author

jjo commented Nov 3, 2017

fwiw mind this being my 1st non-helloworld golang code ;)

@arapulido
Copy link
Contributor

@jjo Can you rebase and resolve conflicts, please?

@ngtuna
Copy link
Contributor

ngtuna commented Nov 6, 2017

Thanks @jjo . This looks good to me. Overall I like this idea to embed static manifest into code. Yes we should skip generated/statik as somehow it will confuses folks. The minor "back side" of this PR which we could do better is requiring folks to do three steps to build the tool. We should put these steps into make file and just do make build. When you have time to rebase, I am happy to merge the PR and update the Makefile and travis for that.

@jjo jjo force-pushed the jjo-use-statik-for-embedded-manifests branch from dee8000 to 5cd8b97 Compare November 6, 2017 19:39
@jjo
Copy link
Contributor Author

jjo commented Nov 6, 2017

Branch updated:

  • rebased + resolved small conflicts
  • adapted Makefile to re-generate embedded content before build
  • removed generated/ from committed code

@ngtuna ngtuna force-pushed the jjo-use-statik-for-embedded-manifests branch from 8d505de to ebeba22 Compare November 7, 2017 04:55
@ngtuna
Copy link
Contributor

ngtuna commented Nov 7, 2017

Thanks @jjo I just added a commit to remove test files and nested vendor and Godeps/ directories so the /vendor folder looks a bit smaller

@ngtuna ngtuna merged commit c85c2ee into vmware-tanzu:master Nov 7, 2017
@jjo jjo deleted the jjo-use-statik-for-embedded-manifests branch November 8, 2017 18:34
prydonius pushed a commit that referenced this pull request Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants