Auto release kubeapps #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ngtuna
commented
Nov 3, 2017
ngtuna
commented
- travis
- Makefile
- version
andresmgot
approved these changes
Nov 5, 2017
.travis.yml
Outdated
| - make VERSION=${TRAVIS_TAG:-build-$TRAVIS_BUILD_ID} binary | ||
|
|
||
| before_deploy: | ||
| - echo TARGET=$TARGET OS_NAME=$TRAVIS_OS_NAME GO_VERSION=$TRAVIS_GO_VERSION |
There was a problem hiding this comment.
is this block for debugging?
.travis.yml
Outdated
| deploy: | ||
| provider: releases | ||
| api_key: | ||
| secure: h+7za6WZBQ6WOGxdux9zztQTW03wE+stVrio8zKVt/fzX5mAphNFoifWcBmvsjm66jHNuhqA5VX5o3phVvf6mbieoxO56CMQzeIg9yIRLM4oWnAdJ4k7ZuOJBRCGtEX0Bs9CgnHzFP8L+Lp+FTe7f31jVll/IPSdvtELzx2ormilK01co201Kctx3yjDG7nWVRygvHcCDY5aLpqcvZVJspwF2izPCsz9GR5+ydCF4w3TvdDqcMxAS3Z+sF8sofnlrnUIWSfrOAmR7qrQpPTR+5gB53h+1rF3kTF49jyvuuCwElUQRl0jsHjX/Uz0qg4d3JPd5TZ16HM6XBtmz6hSkEXoV9o5bwsMG3URODMSk5WVK5WVsMrdJs8i5Ka6KhRSs4/YdoJAy8YlFpMxHdsmycqXBGUw6UahBGdCDxs7KfRSsh713fpQSvOrvupA6NHf/a5atxQcGSLs6uKRV3hvBbP76lYTO8bbf40m5pJ78mG8GVkmezOlygjcPrZmxIl/YYVEYcYhrRJCJk76ok/Iq/HBXJn0cj0aYW52TVitrehDiu+a5EBFs+I66Ib12WFGAFU/VYwkezA42f4Sgvfifa9pzslg8QUcVNBXOteZa7n2Z+6iULorCQ4MlKzv7Mjz/ac1RAEwfd74JP7zV3PDMHeQ2qkzahHwaLDdC9vJ2Vs= |
There was a problem hiding this comment.
please use this user for the CI: /~https://github.com/kubernetes-bitnami
There was a problem hiding this comment.
Ah I forgot that account. Will update 👍
There was a problem hiding this comment.
OK I need a token generated from that account with the public_repo scope. @andresmgot
cmd/version.go
Outdated
| Short: "Print the version of Kubeapps Installer", | ||
| Long: ``, | ||
| Run: func(cmd *cobra.Command, args []string) { | ||
| fmt.Println("Installer version: " + VERSION) |
There was a problem hiding this comment.
Kubeapps installer version:
.travis.yml
Outdated
|
|
||
| before_deploy: | ||
| - echo TARGET=$TARGET OS_NAME=$TRAVIS_OS_NAME GO_VERSION=$TRAVIS_GO_VERSION | ||
| - EXE_NAME=kubeapps-$(go env GOOS)-$(go env GOARCH) |
There was a problem hiding this comment.
shouldn't you export this value?
There was a problem hiding this comment.
That's used for releasing cause I set EXE_NAME as the binary name for each platform (osx, linux)
| - cp kubeapps $EXE_NAME | ||
| - strip $EXE_NAME && ./$EXE_NAME version | ||
| - > | ||
| size $EXE_NAME || : |
There was a problem hiding this comment.
what is this sentence for?
ngtuna
force-pushed
the
v0.0.1-release
branch
2 times, most recently
from
10142f8 to
201dcd2
Compare
ngtuna
force-pushed
the
v0.0.1-release
branch
from
201dcd2 to
656174d
Compare
arapulido
pushed a commit
to arapulido/kubeapps
that referenced
this pull request
Feb 13, 2018
Add a blank target to the Functions URL
prydonius
added a commit
that referenced
this pull request
Feb 23, 2018
Add nginx-ingress, kubeless-ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.