Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(range): use correct color of thumb for disabled state #1070

Merged
merged 7 commits into from
Dec 13, 2023

Conversation

mivaylo
Copy link
Contributor

@mivaylo mivaylo commented Nov 17, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-1449

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

ngModel tends to change template/classes and hence for disabled state our rules for coloring of range's thumbs are overridden

That is why we want to set colors of thumb with !important directive so that the real color is applied and not default gray color

Issue is only caught on Firefox browser

@mivaylo mivaylo marked this pull request as draft November 17, 2023 15:12
Copy link
Contributor

github-actions bot commented Nov 17, 2023

👋 @mivaylo,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

This PR introduces visual changes: 20ce85d
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-1449-fix-disabled-range-thumb-color
git fetch /~https://github.com/vmware-clarity/ng-clarity.git 20ce85d477cace8eec4052e2281294dd00e46fe2
git cherry-pick 20ce85d477cace8eec4052e2281294dd00e46fe2
git push

@mivaylo mivaylo force-pushed the cde-1449-fix-disabled-range-thumb-color branch from bc9e12a to 690dc6e Compare November 17, 2023 15:59
@mivaylo mivaylo marked this pull request as ready for review November 17, 2023 15:59
@mivaylo mivaylo requested a review from a team November 17, 2023 15:59
@dtsanevmw dtsanevmw changed the title fix(range): fix wrong color of thumb for disabled state fix(range): use correct color of thumb for disabled state Nov 27, 2023
@mivaylo
Copy link
Contributor Author

mivaylo commented Nov 27, 2023

Current color of thumb in v16 light CDS theme taken from https://storybook.clarity.design/demo/ranges?cds-theme=light in firefox:

(you can ignore the misplacement as it was already fixed and merged, just not yet released - #1062 )

and in dark CDS theme:

And here is with the fix in this PR:

Copy link
Contributor

This PR introduces visual changes: b6b5cf9
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-1449-fix-disabled-range-thumb-color
git fetch /~https://github.com/vmware-clarity/ng-clarity.git b6b5cf9c8481e1361613b79cf50a4738198860f2
git cherry-pick b6b5cf9c8481e1361613b79cf50a4738198860f2
git push

Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

This PR introduces visual changes: ca4e17c
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-1449-fix-disabled-range-thumb-color
git fetch /~https://github.com/vmware-clarity/ng-clarity.git ca4e17cdd26105ae9a6deeb11a9becea6e5a0a31
git cherry-pick ca4e17cdd26105ae9a6deeb11a9becea6e5a0a31
git push

@mivaylo mivaylo merged commit 4231137 into main Dec 13, 2023
@mivaylo mivaylo deleted the cde-1449-fix-disabled-range-thumb-color branch December 13, 2023 15:00
mivaylo added a commit that referenced this pull request Dec 13, 2023
Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: CDE-1449

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

ngModel tends to change template/classes and hence for disabled state
our rules for coloring of range's thumbs are overridden

That is why we want to set colors of thumb with !important directive so
that the real color is applied and not default gray color

Issue is only caught on Firefox browser

---------

Co-authored-by: GitHub <noreply@github.com>
mivaylo added a commit that referenced this pull request Dec 13, 2023
Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: CDE-1449

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

ngModel tends to change template/classes and hence for disabled state
our rules for coloring of range's thumbs are overridden

That is why we want to set colors of thumb with !important directive so
that the real color is applied and not default gray color

Issue is only caught on Firefox browser

---------

Co-authored-by: GitHub <noreply@github.com>
mivaylo added a commit that referenced this pull request Dec 13, 2023
mivaylo added a commit that referenced this pull request Dec 13, 2023
) (#1083)

## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: CDE-1449

## What is the new behavior?

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

Port of #1070

---------

Co-authored-by: GitHub <noreply@github.com>
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants