-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(range): use correct color of thumb for disabled state #1070
Conversation
👋 @mivaylo,
Thank you, 🤖 Clarity Release Bot |
This PR introduces visual changes: 20ce85d
|
bc9e12a
to
690dc6e
Compare
Current color of thumb in v16 light CDS theme taken from https://storybook.clarity.design/demo/ranges?cds-theme=light in firefox: ![]() (you can ignore the misplacement as it was already fixed and merged, just not yet released - #1062 ) and in dark CDS theme: ![]() And here is with the fix in this PR: ![]() ![]() |
This PR introduces visual changes: b6b5cf9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR introduces visual changes: ca4e17c
|
Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-1449 - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ngModel tends to change template/classes and hence for disabled state our rules for coloring of range's thumbs are overridden That is why we want to set colors of thumb with !important directive so that the real color is applied and not default gray color Issue is only caught on Firefox browser --------- Co-authored-by: GitHub <noreply@github.com>
Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-1449 - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ngModel tends to change template/classes and hence for disabled state our rules for coloring of range's thumbs are overridden That is why we want to set colors of thumb with !important directive so that the real color is applied and not default gray color Issue is only caught on Firefox browser --------- Co-authored-by: GitHub <noreply@github.com>
)" This reverts commit b4ea948.
) (#1083) ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-1449 ## What is the new behavior? ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information Port of #1070 --------- Co-authored-by: GitHub <noreply@github.com>
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: CDE-1449
What is the new behavior?
Does this PR introduce a breaking change?
Other information
ngModel tends to change template/classes and hence for disabled state our rules for coloring of range's thumbs are overridden
That is why we want to set colors of thumb with !important directive so that the real color is applied and not default gray color
Issue is only caught on Firefox browser