-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forms): remove fallbacks and shim relations #995
Conversation
Thank you, 🤖 Clarity Release Bot |
This PR introduces visual changes: 80da519
|
This PR introduces visual changes: 4a91819
|
This PR introduces visual changes: b348adb
|
This PR introduces visual changes: 8aef08c
|
This PR introduces visual changes: 6fa2606
|
This PR introduces visual changes: ede05c3
|
This PR introduces visual changes: f1f2bdb
|
# Conflicts: # tests/snapshots/datagrid/datagrid--variants-core-dark.png # tests/snapshots/datagrid/datagrid--variants-core-light.png # tests/snapshots/login/login--variants-core-dark.png # tests/snapshots/login/login--variants-core-light.png # tests/snapshots/stepper/stepper--variants-core-dark.png # tests/snapshots/stepper/stepper--variants-core-light.png
This PR introduces visual changes: 1d31046
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of screenshot changes here, but they seem largely expected and a result of the typography changes. I would like to preserve component-level CSS variables that are being used by teams unless we have a good reason to remove them.
## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-1235 ## What is the new behavior? ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information --------- Co-authored-by: GitHub <noreply@github.com>
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: CDE-1235
What is the new behavior?
Does this PR introduce a breaking change?
Other information