Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forms): remove fallbacks and shim relations #995

Merged
merged 15 commits into from
Oct 19, 2023

Conversation

valentin-mladenov
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-1235

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@github-actions
Copy link
Contributor

This PR introduces visual changes: 80da519
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout inputs-remove-shim_cde-1235
git fetch /~https://github.com/vmware-clarity/ng-clarity.git 80da519914508517db2ae8f121e61465e912e87e
git cherry-pick 80da519914508517db2ae8f121e61465e912e87e
git push

@github-actions
Copy link
Contributor

This PR introduces visual changes: 4a91819
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout inputs-remove-shim_cde-1235
git fetch /~https://github.com/vmware-clarity/ng-clarity.git 4a9181954c71881e4d5116163c52a072dbf7f98c
git cherry-pick 4a9181954c71881e4d5116163c52a072dbf7f98c
git push

@valentin-mladenov valentin-mladenov removed the request for review from a team October 13, 2023 14:21
@github-actions
Copy link
Contributor

This PR introduces visual changes: b348adb
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout inputs-remove-shim_cde-1235
git fetch /~https://github.com/vmware-clarity/ng-clarity.git b348adbc5ccc7cb9116bf7772f1e81a4d78b0229
git cherry-pick b348adbc5ccc7cb9116bf7772f1e81a4d78b0229
git push

@github-actions
Copy link
Contributor

This PR introduces visual changes: 8aef08c
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout inputs-remove-shim_cde-1235
git fetch /~https://github.com/vmware-clarity/ng-clarity.git 8aef08c64c9d1b73014b354ea434d1ff75522c10
git cherry-pick 8aef08c64c9d1b73014b354ea434d1ff75522c10
git push

@github-actions
Copy link
Contributor

This PR introduces visual changes: 6fa2606
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout inputs-remove-shim_cde-1235
git fetch /~https://github.com/vmware-clarity/ng-clarity.git 6fa2606901a7de215f758821d296e1e6a5e342e4
git cherry-pick 6fa2606901a7de215f758821d296e1e6a5e342e4
git push

@github-actions
Copy link
Contributor

This PR introduces visual changes: ede05c3
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout inputs-remove-shim_cde-1235
git fetch /~https://github.com/vmware-clarity/ng-clarity.git ede05c3d5ae203ae24d2882c9f474968fd6485aa
git cherry-pick ede05c3d5ae203ae24d2882c9f474968fd6485aa
git push

@github-actions
Copy link
Contributor

This PR introduces visual changes: f1f2bdb
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout inputs-remove-shim_cde-1235
git fetch /~https://github.com/vmware-clarity/ng-clarity.git f1f2bdb4783583c1d9fdf6728bc006d8bc48d4f2
git cherry-pick f1f2bdb4783583c1d9fdf6728bc006d8bc48d4f2
git push

# Conflicts:
#	tests/snapshots/datagrid/datagrid--variants-core-dark.png
#	tests/snapshots/datagrid/datagrid--variants-core-light.png
#	tests/snapshots/login/login--variants-core-dark.png
#	tests/snapshots/login/login--variants-core-light.png
#	tests/snapshots/stepper/stepper--variants-core-dark.png
#	tests/snapshots/stepper/stepper--variants-core-light.png
@github-actions
Copy link
Contributor

This PR introduces visual changes: 1d31046
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout inputs-remove-shim_cde-1235
git fetch /~https://github.com/vmware-clarity/ng-clarity.git 1d3104637cf1e1dbf1a667f72622d917d964eb8e
git cherry-pick 1d3104637cf1e1dbf1a667f72622d917d964eb8e
git push

@valentin-mladenov valentin-mladenov requested a review from a team October 17, 2023 11:40
Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of screenshot changes here, but they seem largely expected and a result of the typography changes. I would like to preserve component-level CSS variables that are being used by teams unless we have a good reason to remove them.

@williamernest williamernest changed the title feat(inputs): remove fallbacks and shim relations feat(forms): remove fallbacks and shim relations Oct 17, 2023
@valentin-mladenov valentin-mladenov merged commit cd3c84a into next Oct 19, 2023
@valentin-mladenov valentin-mladenov deleted the inputs-remove-shim_cde-1235 branch October 19, 2023 09:00
mivaylo pushed a commit that referenced this pull request Oct 25, 2023
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [x] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: CDE-1235

## What is the new behavior?

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

---------

Co-authored-by: GitHub <noreply@github.com>
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants