Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wizard): scroll to top of page when page is changed #1698

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

kevinbuhmann
Copy link
Member

PR Type

Bug fix

What is the current behavior?

When you navigate between pages in a wizard, the page is not scrolled to the top. This can be an issue when the pages have long content because you can start in the middle/end of the next page instead of the top.

Issue Number: CDE-2576, #1692

What is the new behavior?

The wizard page will be scroll to the top upon navigation between pages.

Does this PR introduce a breaking change?

No.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@kevinbuhmann kevinbuhmann force-pushed the kevin/wizard-page-scroll branch from a84be32 to ee4b12f Compare February 3, 2025 16:00
@kevinbuhmann kevinbuhmann requested a review from a team February 3, 2025 16:00
@kevinbuhmann kevinbuhmann self-assigned this Feb 3, 2025
@kevinbuhmann kevinbuhmann force-pushed the kevin/wizard-page-scroll branch 3 times, most recently from 1c836fc to 395872a Compare February 3, 2025 16:02
@kevinbuhmann kevinbuhmann changed the title fix(wizard): scroll to top of when page is changed fix(wizard): scroll to top of page when page is changed Feb 3, 2025
@kevinbuhmann kevinbuhmann force-pushed the kevin/wizard-page-scroll branch from 395872a to 12b56c1 Compare February 3, 2025 16:06
Copy link
Contributor

@andyfeds andyfeds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kevinbuhmann kevinbuhmann merged commit e2dfaf9 into main Feb 5, 2025
12 checks passed
@kevinbuhmann kevinbuhmann deleted the kevin/wizard-page-scroll branch February 5, 2025 04:19
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants