Datagrid: hiding the last column adds whitespaces at the end and shows scrollbar #1501
Assignees
Comments
13 tasks
dtsanevmw
added a commit
that referenced
this issue
Oct 14, 2024
## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? Currently we have a CSS selector for `:last-child` to hide the separator from the column but when the last column gets hidden that's happening only visually and it's still in the DOM so that's not working. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-2317, #1501 ## What is the new behavior? Update showSeparator states when hidden state changes. ## Does this PR introduce a breaking change? - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information
github-actions bot
pushed a commit
that referenced
this issue
Oct 14, 2024
## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? Currently we have a CSS selector for `:last-child` to hide the separator from the column but when the last column gets hidden that's happening only visually and it's still in the DOM so that's not working. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-2317, #1501 ## What is the new behavior? Update showSeparator states when hidden state changes. ## Does this PR introduce a breaking change? - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information (cherry picked from commit b4a4935)
13 tasks
|
Fixed in b4a4935 and it will be in the next release. |
dtsanevmw
added a commit
that referenced
this issue
Oct 14, 2024
…to 16.x) (#1591) Backport b4a4935 from #1584. <br> ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? Currently we have a CSS selector for `:last-child` to hide the separator from the column but when the last column gets hidden that's happening only visually and it's still in the DOM so that's not working. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-2317, #1501 ## What is the new behavior? Update showSeparator states when hidden state changes. ## Does this PR introduce a breaking change? - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information Co-authored-by: Daniel Tsanev <127101685+dtsanevmw@users.noreply.github.com>
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is a bug report for the
@clrAngular or UI versions of the design system.For the web-component implementation of Clarity (
@cds), visit vmware-clarity/core.If you are a VMware employee or a contractor in VMware, please use our support space in Google Chat to raise Clarity issues.
Describe the bug
Hiding the last column of a datagrid ends up in showing some whitespaces a the end of the datagrid in addition to the scrollbar.
Showing all columns
Hiding non-last column
Hiding last column
How to reproduce
This behavior can also be seen with the provided example in the documentation.
Steps to reproduce the behavior:
Expected behavior
No whitespaces and no scrollbar when hiding the last element.
Versions
Clarity version:
Framework version:
"@angular/core": "~17.1.2",Device:
Additional notes
Add any other notes about the problem here.
The text was updated successfully, but these errors were encountered: