This repository has been archived by the owner on Sep 26, 2022. It is now read-only.
fix: Fixes #256, added ability to associate all fields after processing #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
February 8, 2022 08:38
Signed-off-by: Dustin Scott <sdustin@vmware.com>
This commit addresses a panic situation when the workload itself references a collection field, however the workload itself is not using a collection field as an input to any of its fields. Signed-off-by: Dustin Scott <sdustin@vmware.com>
Signed-off-by: Dustin Scott <sdustin@vmware.com>
Signed-off-by: Dustin Scott <sdustin@vmware.com>
Signed-off-by: Dustin Scott <sdustin@vmware.com>
Signed-off-by: Dustin Scott <sdustin@vmware.com>
Signed-off-by: Dustin Scott <sdustin@vmware.com>
Signed-off-by: Dustin Scott <sdustin@vmware.com>
This simply is a reminder to prepare for a test case for #271. It does not include an empty line, as an empty line would break the test case. Once in order to produce our functional test to account for this. Signed-off-by: Dustin Scott <sdustin@vmware.com>
This adds the 'omitempty' tag to all fields within the API. This allows the unmarshal to unmarshal with empty fields. Without the 'omitempty' tag, the unmarshal event results in zero values before it can be processed by the CRD which is there to set the default values. Signed-off-by: Dustin Scott <sdustin@vmware.com>
Signed-off-by: Dustin Scott <sdustin@vmware.com>
Signed-off-by: Dustin Scott <sdustin@vmware.com>
Signed-off-by: Dustin Scott <sdustin@vmware.com>
Signed-off-by: Dustin Scott <sdustin@vmware.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.