This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an initial pass at supporting ephemeral containers in Octant. If the feature gate is enabled when visiting a pod, it will automatically add debug container using a debian image.
Pods with an ephemeral container will have their object status modified as
warning
(yellow).If there is interest in this feature, further efforts can be invested into making the debug container configurable and proper UI.
Which issue(s) this PR fixes
Special notes for your reviewer:
Example of a distroless image where
sh
andbash
will not work:Testing if a feature gate is enabled using mocked clients is not straightforward and I haven't figured out a way to do this yet. The terminal viewer component is pending a refactor soon because the terminal viewer does not have knowledge of the manager's state which causes unnecessary synchronization challenges.
Signed-off-by: GuessWhoSamFoo foos@vmware.com