Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Plugin watcher error should provide better information. #1273

Closed
wwitzel3 opened this issue Aug 21, 2020 · 0 comments · Fixed by #2776
Closed

Plugin watcher error should provide better information. #1273

wwitzel3 opened this issue Aug 21, 2020 · 0 comments · Fixed by #2776
Assignees
@xtreme-vikram-yadav
Labels
api bug Something isn't working plugin

Comments

@wwitzel3
Copy link
Contributor

The plugin watcher currently logs a warning if it cannot watch a plugin folder.

    2020-08-21T15:04:44.208-0400    WARN    plugin/manager.go:364   unable to add /Users/scothis/.config/octant/plugins to JavaScript plugin watcher
github.com/vmware-tanzu/octant/pkg/plugin.(*Manager).watchJS
        /Users/scothis/Development/vmware-tanzu/octant/pkg/plugin/manager.go:364
    2020-08-21T15:04:44.208-0400    INFO    plugin/manager.go:368   watching for new JavaScript plugins in ["/Users/scothis/.config/octant/plugins"]

This is confusing and is masks the actual error. Current code /~https://github.com/vmware-tanzu/octant/blob/master/pkg/plugin/manager.go#L362

Update this to display the error with the warning message and to not display any directories we failed to watch as being watched.
@wwitzel3 wwitzel3 added bug Something isn't working api plugin labels Aug 21, 2020
@xtreme-vikram-yadav xtreme-vikram-yadav self-assigned this Aug 18, 2021
xtreme-vikram-yadav pushed a commit to xtreme-vikram-yadav/octant that referenced this issue Aug 18, 2021
Show error for JS plugin watcher
882b12e 
vmware-archive#1273
@xtreme-vikram-yadav xtreme-vikram-yadav mentioned this issue Aug 18, 2021
Merged
xtreme-vikram-yadav pushed a commit to xtreme-vikram-yadav/octant that referenced this issue Aug 18, 2021
Show error for JS plugin watcher
22edfd4 
Signed-off-by: Vikram Yadav <yvikram@vmware.com>

vmware-archive#1273
xtreme-vikram-yadav pushed a commit to xtreme-vikram-yadav/octant that referenced this issue Aug 18, 2021
Show error for JS plugin watcher
b8eeec3 
Signed-off-by: Vikram Yadav <yvikram@vmware.com>

vmware-archive#1273
xtreme-vikram-yadav pushed a commit to xtreme-vikram-yadav/octant that referenced this issue Aug 18, 2021
Show error for JS plugin watcher
6bc2d22 
Signed-off-by: Vikram Yadav <yvikram@vmware.com>

vmware-archive#1273
xtreme-vikram-yadav pushed a commit to xtreme-vikram-yadav/octant that referenced this issue Aug 23, 2021
Show error for JS plugin watcher
0666cae 
Signed-off-by: Vikram Yadav <yvikram@vmware.com>

vmware-archive#1273
GuessWhoSamFoo pushed a commit that referenced this issue Aug 27, 2021
Show error for JS plugin watcher (#2776)
d01da3d 
* Show error for JS plugin watcher

Signed-off-by: Vikram Yadav <yvikram@vmware.com>

#1273

* log plugin startup errors and resume octant startup

- Do not error out from octant when plugin startup fails

Signed-off-by: Vikram Yadav <yvikram@vmware.com>

#2796
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xtreme-vikram-yadav xtreme-vikram-yadav

Labels
api bug Something isn't working plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show error for JS plugin watcher xtreme-vikram-yadav/octant
2 participants
@wwitzel3 @xtreme-vikram-yadav