This repository has been archived by the owner on Feb 9, 2022. It is now read-only.
split tslint rules for dev and ci #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In development, console.log's are useful for debugging. This updates the main tslint.json file to not error when console.log's are present, but to just emit warnings. Since tslint doesn't have a stricter mode where it fails on warnings also, I've created another tslint.ci.json file that will emit errors if console.log's are present. This file will be used in the CI and pre-commit hooks so when a developer is ready to commit a change they will need to remove their debug statements.
Angelmmiguel
approved these changes
Feb 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In development, console.log's are useful for debugging. This updates the
main tslint.json file to not error when console.log's are present, but
to just emit warnings. Since tslint doesn't have a stricter mode where
it fails on warnings also, I've created another tslint.ci.json file that
will emit errors if console.log's are present. This file will be used in
the CI and pre-commit hooks so when a developer is ready to commit a
change they will need to remove their debug statements.