Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): don't fail when running --browser.headless if the browser projest is part of the workspace #7311

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

sheremet-va
Copy link
Member

Description

Closes #7300

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 8486c83
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/678e6bc88053950008628ef8
😎 Deploy Preview https://deploy-preview-7311--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va merged commit e43a8f5 into vitest-dev:main Jan 20, 2025
13 checks passed
@sheremet-va sheremet-va deleted the fix/allow-browser-headless branch January 20, 2025 16:24
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Jan 21, 2025
##### [v3.0.3](/~https://github.com/vitest-dev/vitest/releases/tag/v3.0.3)

#####    🐞 Bug Fixes

-   **browser**:
    -   Don't throw a validation error if v8 coverage is used with filtered instances  -  by [@sheremet-va](/~https://github.com/sheremet-va) in vitest-dev/vitest#7306 [<samp>(fa463)</samp>](vitest-dev/vitest@fa4634b2)
    -   Don't fail when running --browser.headless if the browser projest is part of the workspace  -  by [@sheremet-va](/~https://github.com/sheremet-va) in vitest-dev/vitest#7311 [<samp>(e43a8)</samp>](vitest-dev/vitest@e43a8f56)

#####    🏎 Performance

-   **reporters**: Update summary only when needed  -  by [@AriPerkkio](/~https://github.com/AriPerkkio) in vitest-dev/vitest#7291 [<samp>(7f36b)</samp>](vitest-dev/vitest@7f36b6f9)

#####     [View changes on GitHub](vitest-dev/vitest@v3.0.2...v3.0.3)
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Jan 21, 2025
##### [v3.0.3](/~https://github.com/vitest-dev/vitest/releases/tag/v3.0.3)

#####    🐞 Bug Fixes

-   **browser**:
    -   Don't throw a validation error if v8 coverage is used with filtered instances  -  by [@sheremet-va](/~https://github.com/sheremet-va) in vitest-dev/vitest#7306 [<samp>(fa463)</samp>](vitest-dev/vitest@fa4634b2)
    -   Don't fail when running --browser.headless if the browser projest is part of the workspace  -  by [@sheremet-va](/~https://github.com/sheremet-va) in vitest-dev/vitest#7311 [<samp>(e43a8)</samp>](vitest-dev/vitest@e43a8f56)

#####    🏎 Performance

-   **reporters**: Update summary only when needed  -  by [@AriPerkkio](/~https://github.com/AriPerkkio) in vitest-dev/vitest#7291 [<samp>(7f36b)</samp>](vitest-dev/vitest@7f36b6f9)

#####     [View changes on GitHub](vitest-dev/vitest@v3.0.2...v3.0.3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3] Browser Mode: Error when running npx vitest --browser.headless
1 participant