feat(reporter): show gzip info for all compressible files (fix #11288) #12485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@ArnaudBarre Please let me know if I can improve anything. This is my first PR, here 🎉 |
ArnaudBarre
reviewed
Mar 19, 2023
mojoaxel
force-pushed
the
11288-show-gzip-info-for-all-compressible-files
branch
from
be2b8fb to
0378c91
Compare
ArnaudBarre
previously approved these changes
Mar 19, 2023
bluwy
reviewed
Mar 21, 2023
bluwy
added
the
p2-nice-to-have
7 tasks
mojoaxel
force-pushed
the
11288-show-gzip-info-for-all-compressible-files
branch
from
0378c91 to
afba870
Compare
mojoaxel
requested review from
bluwy and
ArnaudBarre
and removed request for
bluwy
ArnaudBarre
reviewed
Mar 21, 2023
mojoaxel
force-pushed
the
11288-show-gzip-info-for-all-compressible-files
branch
from
afba870 to
51a46da
Compare
ArnaudBarre
approved these changes
Mar 21, 2023
patak-dev
approved these changes
Mar 23, 2023
|
.wasm files are generally highly compressible as well. One file I have went from 89.3K to 20.1K after gzip. It'd be nice to see that extension included as well. |
Feel free to add |
yurivish
added a commit
to yurivish/vite
that referenced
this pull request
Dec 27, 2024
Wasm files are often highly compressible and it would be nice to show their compressed size in Vite builds. I found an earlier PR (vitejs#12485) that made this change for some other asset types, and a [comment](vitejs#12485 (comment)) that sounded open to the addition of wasm to the list, which I've added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix/feature-update for #11288
The reporter plugin should show gzip information not only for
jsandcssfiles but also for other compressible files likesvg,html.Additional context
see #11288 (comment)
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).We need to further discuss the liste of file-extensions we want to show the gzip information for.