Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting Vite 6 #207

Merged
merged 21 commits into from
Nov 26, 2024
Merged

Supporting Vite 6 #207

merged 21 commits into from
Nov 26, 2024

Conversation

RobinTail
Copy link
Contributor

@RobinTail RobinTail commented May 20, 2024

I tested it manually (in my project) and I ran the tests in this repo.

scripts/bundle.ts Outdated Show resolved Hide resolved
@ArnaudBarre
Copy link
Member

Hey thanks for this! I've done some changes in #208 to help fix the tests, the change in connected. message will be reverted soon.

Why are you currently testing Vite 6? Have you any interest in the new environment API?
For info it would not be release soon, but if you have any feedback on this you can join the discord!

@RobinTail
Copy link
Contributor Author

Why are you currently testing Vite 6?

I like it when plugins for an important software are prepared for the major update of that software in advance.
I want this plugin to be ready when Vite 6 released, so that it would not be a blocker for migrating to Vite 6, @ArnaudBarre

@RobinTail
Copy link
Contributor Author

RobinTail commented Sep 15, 2024

The following workspace might require its own earlier version of rollup, because the one coming from vite (4.21.3) is not declared as a compatible one with @mdx-js/rollup — the latest version of which (3.0.1) is currently installed there needs v3 max. However, it still works anyway.

 WARN  Issues with peer dependencies found
playground/mdx
└─┬ @mdx-js/rollup 3.0.1
  └─┬ @rollup/pluginutils 5.0.2
    └── ✕ unmet peer rollup@^1.20.0||^2.0.0||^3.0.0: found 4.21.3

UPD: there is a newer version of @rollup/pluginutils supporting rollup 4. Just need an update/reinstallation of that dependency branch.

✅ UPD: fixed in b03d3d0

@RobinTail RobinTail marked this pull request as ready for review November 26, 2024 09:54
@RobinTail
Copy link
Contributor Author

@ArnaudBarre ,

Please review. It's time :)

Screenshot 2024-11-26 at 10 50 53

@ArnaudBarre ArnaudBarre merged commit def0148 into vitejs:main Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants