Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trap tab focus in modal when hitting s-tab #4075

Merged
merged 1 commit into from
Feb 21, 2017
Merged

fix: trap tab focus in modal when hitting s-tab #4075

merged 1 commit into from
Feb 21, 2017

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Feb 13, 2017

Pretend that the modal dialog is equivalent to the first
focusable/tabbable element when hitting shift-tab.

Fix #4049

@gkatsev
fix: trap tab focus in modal when hitting s-tab
1fffd06 
Pretend that the modal dialog is equivalent to the first
focusable/tabbable element when hitting shift-tab.

Fix #4049
@gkatsev gkatsev added the a11y This item might affect the accessibility of the player label Feb 13, 2017
@gkatsev gkatsev requested a review from OwenEdwards February 13, 2017 22:16
brandonocasey
brandonocasey reviewed Feb 16, 2017
View reviewed changes
Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good here but I think it would be good to test this after we get the captions settings revamp into master

misteroneill
misteroneill approved these changes Feb 16, 2017
View reviewed changes
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

OwenEdwards
OwenEdwards approved these changes Feb 17, 2017
View reviewed changes
Copy link
Member

@OwenEdwards OwenEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkatsev
Copy link
Member Author

gkatsev commented Feb 21, 2017

Tests are passing locally, just timing out on browserstack.

@gkatsev gkatsev merged commit 1f7a842 into master Feb 21, 2017
@gkatsev gkatsev deleted the modal-shift-tab branch February 21, 2017 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonocasey brandonocasey brandonocasey left review comments

@misteroneill misteroneill misteroneill approved these changes

@OwenEdwards OwenEdwards OwenEdwards approved these changes

Assignees
No one assigned
Labels
a11y This item might affect the accessibility of the player confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gkatsev @misteroneill @OwenEdwards @brandonocasey