Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): update fullscreen methods to return promises #147

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

jansgescheit
Copy link
Contributor

Description

Updated the toggleFullscreen, request, enterElementInFullScreen, and exit methods in VgFullscreenApiService to return Promise<void>. This change ensures consistency and allows for better handling of asynchronous operations related to fullscreen actions.

#146

Checklist

Please, check that you have been followed next steps:

  • I've read the (contributing)[/~https://github.com/videogular/ngx-videogular/blob/master/CONTRIBUTING.md] guidelines
  • Code compiles correctly (run npm start)
  • Created tests (if necessary)
  • All tests passing (run npm test)
  • Extended the README / documentation (if necessary)

Updated the `toggleFullscreen`, `request`, `enterElementInFullScreen`, and `exit` methods in `VgFullscreenApiService` to return `Promise<void>`. This change ensures consistency and allows for better handling of asynchronous operations related to fullscreen actions.
@IxquitilisSaid IxquitilisSaid self-requested a review October 10, 2024 09:55
@IxquitilisSaid IxquitilisSaid added the bug Something isn't working label Oct 10, 2024
@IxquitilisSaid
Copy link
Member

LGTM

@IxquitilisSaid IxquitilisSaid merged commit 9a345d9 into videogular:master Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants