Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(player): add descendants option in contentchildren #113

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

tomstolarczuk
Copy link
Contributor

Description

This option is required in new Angular version, otherwise it doesn't know how to collect nested children in ng-content.

Checklist

Please, check that you have been followed next steps:

  • I've read the (contributing)[/~https://github.com/videogular/ngx-videogular/blob/master/CONTRIBUTING.md] guidelines
  • Code compiles correctly (run npm start)
  • Created tests (if necessary)
  • All tests passing (run npm test)
  • Extended the README / documentation (if necessary)

@IxquitilisSaid IxquitilisSaid self-assigned this Jan 10, 2023
@IxquitilisSaid IxquitilisSaid added the enhancement New feature or request label Jan 10, 2023
@IxquitilisSaid
Copy link
Member

LGTM. Thanks for the contribution!

@IxquitilisSaid IxquitilisSaid merged commit c26fb95 into videogular:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants