Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump Svelte example to Svelte v5 #9981

Merged
merged 4 commits into from
Feb 25, 2025
Merged

chore: bump Svelte example to Svelte v5 #9981

merged 4 commits into from
Feb 25, 2025

Conversation

joshnuss
Copy link
Contributor

Description

This PR migrates the Svelte example to Svelte v5.

It was performed by running pnpx npm-check-updates -u in all packages in examples/with-svelte directory.

Also ran pnpx sv migrate svelte-5 in examples/with-svelte/packages/ui.

Testing Instructions

In examples/with-svelte, run pnpm dev and visit web and docs sites to verify it's working.

This does not impact any automated tests.

@joshnuss joshnuss requested a review from a team as a code owner February 15, 2025 10:57
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage labels Feb 15, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 11:37pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 11:37pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 11:37pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 11:37pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 11:37pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 11:37pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 11:37pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 11:37pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 11:37pm

@vercel Vercel
Copy link

vercel bot commented Feb 15, 2025

@joshnuss is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@joshnuss joshnuss mentioned this pull request Feb 15, 2025
Closed
@joshnuss joshnuss changed the title chore: Bump Svelte example to Svelte v5 chore: bump Svelte example to Svelte v5 Feb 15, 2025
@anthonyshew
Copy link
Contributor

This looks good - except the lockfile needs to be updated! Once you do that, we can merge it. 👍

@joshnuss
Copy link
Contributor Author

@anthonyshew Updated the lockfile.

@anthonyshew
Copy link
Contributor

Thanks! I'm seeing this is causing some breaks in CI while testing the build forthe example. Do you know why that is?
/~https://github.com/vercel/turborepo/actions/runs/13372619143/job/37344774656?pr=9981

@joshnuss
Copy link
Contributor Author

hmm, I'm not sure why. On local machine vite build works fine.
I will try to run the CI locally tomorrow (on a slow connection rn, and it will take forever to download docker images)

@anthonyshew
Copy link
Contributor

I think I've narrowed down that this is something unique to the way these tests are being ran in CI and/or the way we're running them. I see the example itself working just fine.

It's likely you'll want to wait on me doing a deep dive here, as something seems to be amiss on our end.

@joshnuss
Copy link
Contributor Author

Ok, thanks @anthonyshew 🙏

@anthonyshew anthonyshew mentioned this pull request Feb 24, 2025
Closed
anthonyshew
anthonyshew approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshnuss, sorry for that delay. Looks like I got it ironed out with this.

Looks to be green now! Is there anything else you'd want to update before merging?

@joshnuss
Copy link
Contributor Author

Thanks @anthonyshew 🙏

Nothin to add from my side. I think it good to go

@anthonyshew anthonyshew merged commit 5c2a23c into vercel:main Feb 25, 2025
35 checks passed
@anthonyshew
Copy link
Contributor

anthonyshew commented Feb 25, 2025 •
edited
Loading

Sounds great! Thank you again for doing this. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyshew anthonyshew anthonyshew approved these changes

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos dimitropoulos is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshnuss @anthonyshew