feat(boundaries): ignore svelte and vue files (but warn) #9886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tknickman
approved these changes
Feb 3, 2025
Also extended to mjs and cjs files
NicholasLYang
force-pushed
the
nicholasyang/remove-svelte-vue
branch
from
7eb4689 to
0aced63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SWC currently cannot parse svelte or vue. Therefore we ignore them when it comes to boundaries, but we do emit a warning for users. Note that we specifically do not emit a warning per file, since that could be a lot of warnings. We do however emit per package, but that should hopefully not be too excessive
closes #9874
Testing Instructions