feat(boundaries): ignore nested workspaces #9840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
requested changes
Jan 29, 2025
crates/turborepo-globwalk/src/lib.rs
Outdated
| "/repos/some-app/tests/mocks/spanish-inquisition/package.json", | ||
| ], | ||
| "/repos/some-app/", | ||
| &["**/package.json"], |
There was a problem hiding this comment.
Can you change the test case to better match how this setting gets used in boundaries e.g. a glob of **/*.js and making sure it doesn't pick up js files in /repos/some-app/node_modules/, but still picks up JS files in /repos/some-app/apps/web/src/index.js
There was a problem hiding this comment.
Changed, although to be clear, we wouldn't pick up /repos/some-app/apps/web/src/index.js because apps/web is a package and we don't recurse into packages with this setting
chris-olszewski
approved these changes
Jan 30, 2025
NicholasLYang
force-pushed
the
nicholasyang/boundaries-nested-workspaces
branch
from
525f3c2 to
847fbed
Compare
NicholasLYang
force-pushed
the
nicholasyang/boundaries-nested-workspaces
branch
from
847fbed to
b7c4382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nested workspaces break a lot of our boundaries checks. This PR adds a setting to glob walking to ignore nested workspaces, and uses it for boundaries.
Testing Instructions
Added a test to
turborepo-globwalkfor the underlying setting. And added a nested package toboundariesfixture