Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): use windows-sys instead of winapi #9805

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

ognevny
Copy link
Contributor

@ognevny ognevny commented Jan 27, 2025

Description

winapi is abandoned and had no updates since 2020, while windows-sys is supported by Microsoft. also updated winapi-util to use windows-sys too

Testing Instructions

@ognevny ognevny requested a review from a team as a code owner January 27, 2025 09:50
@turbo-orchestrator turbo-orchestrator bot added the needs: triage New issues get this label. Remove it after triage label Jan 27, 2025
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:28am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:28am
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:28am
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:28am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:28am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:28am
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:28am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:28am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:28am

Copy link

vercel bot commented Jan 27, 2025

@ognevny is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented Jan 27, 2025

Allow CI Workflow Run

  • approve CI run for commit: 283196a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Jan 27, 2025

Allow CI Workflow Run

  • approve CI run for commit: 283196a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@chris-olszewski chris-olszewski merged commit ebc4075 into vercel:main Jan 29, 2025
38 checks passed
@ognevny ognevny deleted the use-windows-sys branch January 29, 2025 04:37
chris-olszewski pushed a commit that referenced this pull request Jan 29, 2025
### Description

~the same reason as for #9805, but for turborepo-wax. the package update
fully removes winapi from lockfile. also cargo updated many packages for
unknown reason (I've run `cargo update -p winapi-util`)~

as asked in review lockfile is deleted
<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants