chore: upgrade to Rust 1.83.0 #9652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
the
needs: triage
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ognevny is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
chris-olszewski
approved these changes
Jan 16, 2025
Comment on lines
+89
to
+90
| // Child::wait is run after writing `s` into stdin | ||
| #[allow(clippy::zombie_processes)] |
There was a problem hiding this comment.
This is actually a valid lint. If we fail to write to the child's stdin then we will end up with a zombie processes as we exit before calling wait
There was a problem hiding this comment.
refactor is needed to fix this lint...
chris-olszewski
changed the title
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
2 similar comments
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
chris-olszewski
removed
the
needs: triage
turbo-orchestrator
bot
added
the
needs: triage
chris-olszewski
added a commit
that referenced
this pull request
Jan 16, 2025
### Description As discovered in #9652 (comment) We could create a zombie process if writing to the clipboard program failed as we handled the write failure without `wait`ing the clipboard process. ### Testing Instructions We no longer get a lint warning when removing `allow(clippy::zombie_process)`
This was referenced Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
needless_lifetimesexcluding turborepo-lib as code generated by tonic-build are also lint so there is 50+ warnings :(zombie_processonce as it's buggyTesting Instructions