Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(env): add VERCEL_ENV into default global env map #9635

Conversation

chris-olszewski
Copy link
Member

Description

Include VERCEL_ENV as an environment variable that affects the global hash. Can be opted out by specifying !VERCEL_ENV in globalEnv.

Testing Instructions

Unit test, quick manual test as a smoke test:

[0 olszewski@chriss-mbp] /tmp/env-var $ VERCEL_ENV=dev turbo_dev --skip-infer build --output-logs=hash-only --ui=stream
turbo 2.3.4-canary.4

• Packages in scope: @repo/eslint-config, @repo/typescript-config, @repo/ui, docs, web
• Running build in 5 packages
• Remote caching disabled
web:build: cache miss, executing 7a2bad92132801df
docs:build: cache miss, executing 744d362ee9e1eb1b

 Tasks:    2 successful, 2 total
Cached:    0 cached, 2 total
  Time:    13.166s 

[0 olszewski@chriss-mbp] /tmp/env-var $ VERCEL_ENV=dev turbo_dev --skip-infer build --output-logs=hash-only --ui=stream
turbo 2.3.4-canary.4

• Packages in scope: @repo/eslint-config, @repo/typescript-config, @repo/ui, docs, web
• Running build in 5 packages
• Remote caching disabled
docs:build: cache hit, suppressing logs 744d362ee9e1eb1b
web:build: cache hit, suppressing logs 7a2bad92132801df

 Tasks:    2 successful, 2 total
Cached:    2 cached, 2 total
  Time:    108ms >>> FULL TURBO

[0 olszewski@chriss-mbp] /tmp/env-var $ VERCEL_ENV=prod turbo_dev --skip-infer build --output-logs=hash-only --ui=stream
turbo 2.3.4-canary.4

• Packages in scope: @repo/eslint-config, @repo/typescript-config, @repo/ui, docs, web
• Running build in 5 packages
• Remote caching disabled
web:build: cache miss, executing b138cc0b45044f36
docs:build: cache miss, executing 0149788cd6331b71

 Tasks:    2 successful, 2 total
Cached:    0 cached, 2 total
  Time:    9.355s

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 8:30pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 8:30pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 8:30pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 8:30pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 8:30pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 8:30pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 8:30pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 8:30pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 8:30pm

@chris-olszewski chris-olszewski marked this pull request as ready for review December 19, 2024 20:30
@chris-olszewski chris-olszewski requested a review from a team as a code owner December 19, 2024 20:30
Copy link
Member

@tknickman tknickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend

@chris-olszewski chris-olszewski enabled auto-merge (squash) December 19, 2024 20:32
@chris-olszewski chris-olszewski merged commit 5c74fe9 into main Dec 19, 2024
35 checks passed
@chris-olszewski chris-olszewski deleted the chrisolszewski/turbo-4272-investigate-always-adding-vercel_env-to-cache-key-on-vercel branch December 19, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants