chore: refactor should_print_version into helper for clarity
#10006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
the
needs: triage
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
erikareads
changed the title
should_print_version into helper for clarityshould_print_version into helper for clarity
chris-olszewski
approved these changes
Feb 19, 2025
chris-olszewski
deleted the
erikarowland/refactor-should-print-version
branch
This was referenced Feb 19, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small refactor pulling the boolean condition
should_print_versioninto a helper function with the same name. I also decompose the boolean condition into the two relevant states: whether print version is disabled by environment variable, and whether this run ofturbois in continuous integration.I used
enums to disambiguate these states, because previously we were negating a negative boolean to produce a positive one, and it would easy during modification to inadvertently produce opposite behavior by forgetting a negation. The enums make it clear which state each of the two relevant conditions are in, and make the final boolean calculation easy to read.