publish flow fixes #28050
Merged
publish flow fixes #28050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padmaia
requested review from
huozhi,
ijjk,
shuding,
styfle and
timneutkens
as code owners
ijjk
approved these changes
Aug 13, 2021
padmaia
commented
Aug 13, 2021
| @@ -15,7 +15,7 @@ fi | |||
| if [[ $(git describe --exact-match 2> /dev/null || :) =~ -canary ]]; | |||
| then | |||
| echo "Publishing canary" | |||
| yarn run lerna publish from-git --npm-tag canary --yes | |||
| yarn run lerna publish from-git --npm-tag canary --no-git-reset --yes | |||
There was a problem hiding this comment.
--no-git-reset makes lerna okay with git update-index --skip-worktree. It seems like we would be interested in the feature proposed in this issue.
ijjk
reviewed
Aug 13, 2021
| @@ -15,7 +15,7 @@ const cwd = process.cwd() | |||
|
|
|||
| // Copy binaries to package folders, update version, and publish | |||
| let nativePackagesDir = path.join(cwd, 'packages/next/build/swc/npm') | |||
| let platforms = await (await readdir(nativePackagesDir)).filter( | |||
| let platforms = await readdir(nativePackagesDir).filter( | |||
There was a problem hiding this comment.
It looks like this await readdir still needs to be wrapped
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested theses changes end to end in my fork (published under my personal scope with some irrelevant jobs skipped to speed up iteration)