Terser #4191
Merged
Terser #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LabhanshAgrawal hey, what do you think about this? File size is a bit bigger because I only went with the default options for terser but otherwise looks cool? |
LabhanshAgrawal
suggested changes
Jan 21, 2020
|
Looks good, Is this for #4115 ? |
|
Yes, part of it. Mostly minify is pretty dead at the moment babel/minify#952 |
|
Can you add a condition for checking the isProd variable, would be easier to debug during development |
|
Need to change the webpack config a little to use the type information. I can't add changes to the pr, so I've pushed it here, you can cherrypick the latest commit, if the change seems ok to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.