Lock hooks and injection behind feature flags #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh my, that was an oversight and a half on my end 😅 Thank you for this PR! LGTM 😄 Could you please elaborate on your issue (on #96, or a new issue, should be good) so I can try and reproduce it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locked all hooks and the injection part behind the feature flags, injection is behind
inject.Regarding #96 - It's fixed with this as I only enable OGL3, but there's another new issue that only occur with the Linux -> Windows build process, where it fails get some user profile directory (logged by CE).
Not a big deal, but if you got time to look into it, please do.