Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dependencies #105

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Simplify dependencies #105

merged 1 commit into from
Jun 8, 2023

Conversation

vsylva
Copy link
Contributor

@vsylva vsylva commented May 28, 2023

Removed the "widestring" dependency

Test passed

    // Ok
    // let process = hudhook::inject::Process::by_name("re8.exe").unwrap();

    // Ok
    // let process = hudhook::inject::Process::by_name("re8.exe\0 I don't care about this stuff").unwrap();

    // Ok
    // let process = hudhook::inject::Process::by_title("Resident Evil Village").unwrap();

    // Ok
    let process =
        hudhook::inject::Process::by_title("Resident Evil Village\0 I don't care about this stuff")
            .unwrap();

    // Ok
    process.inject("d3d11.dll".into()).unwrap();

Removed the "widestring" dependency
@veeenu
Copy link
Owner

veeenu commented May 31, 2023

Thank you for this! I need a bit of time for a proper review but pruning dependencies in this way is absolutely great.

@veeenu veeenu merged commit 04264ee into veeenu:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants