Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert platforms to Typescript #13756

Merged
merged 4 commits into from
May 22, 2020
Merged

Convert platforms to Typescript #13756

merged 4 commits into from
May 22, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 21, 2020

t3chguy added 3 commits May 20, 2020 19:56
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team May 21, 2020 17:09
@t3chguy
Copy link
Member Author

t3chguy commented May 21, 2020

tests failing due to mismatched branches, will rerun once dependency gets merged

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 😁

src/vector/platform/VectorBasePlatform.ts Show resolved Hide resolved
@t3chguy t3chguy merged commit b4284b4 into develop May 22, 2020
@t3chguy t3chguy deleted the t3chguy/toasts2 branch May 22, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants