Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Convert BasePlatform and BaseEventIndexManager to Typescript #4614

Merged
merged 3 commits into from
May 22, 2020
Merged

Convert BasePlatform and BaseEventIndexManager to Typescript #4614

merged 3 commits into from
May 22, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 21, 2020 •
edited
Loading

Subset of #4609

@t3chguy
Convert BasePlatform and BaseEventIndexManager to Typescript
b27f1fa 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team May 21, 2020 17:09
@t3chguy t3chguy mentioned this pull request May 21, 2020
Merged
t3chguy added 2 commits May 21, 2020 18:11
@t3chguy
delint
7b0e51a 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
make ts happy
3ae3871 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
jryans
jryans approved these changes May 22, 2020
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks reasonable to me!

@t3chguy t3chguy merged commit 696f158 into develop May 22, 2020
@t3chguy t3chguy deleted the t3chguy/toasts2 branch May 22, 2020 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @jryans