-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FirebaseAuth identity token #207
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
+ Coverage 77.20% 83.68% +6.47%
==========================================
Files 55 56 +1
Lines 1347 1483 +136
==========================================
+ Hits 1040 1241 +201
+ Misses 307 242 -65
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Just missing some formatting. Feel free to run swift format --recursive --in-place .
with /~https://github.com/vapor/contributing/blob/main/.swift-format in the project's directory. While you're at it could you add some names to the @Test
s which were missing? Something similar to the other test suites should be fine
@ptoffy done, please take another look. Not sure though why the windows CI pass failed on some CCryptoBoringSSL (linker?) errors? |
Yeah looks like this should fix it apple/swift-crypto@4518e5e but there hasn't been a release yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few whitespace nits to be in par with the rest of the repo. I would have thought swift-format would catch these but maybe we need to be stricter 🤷
Thanks, I'll fix those. Yeah, I just ran swift-format before pushing the changes, relying on that I'd fix everything for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
These changes are now available in 5.1.0
FirebaseAuthIdentityToken
.Adding support for Firebase Authentication was okayed by @ptoffy, see here vapor/jwt#159.
I'll also follow up with a PR for /~https://github.com/vapor/jwt once this is merged in.