Fix decimal and nil header encoding #189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix the issues discovered in #188
nil
wasn't being added because assigningnil
to a field would remove it from the dict. Now assigningnil
to a field actually adds an explicit null value to the json, while there's aremove(field:)
method to remove fields from the headerdecimal
wasn't being decoded correctly because it was trying to unwrapDouble
s asInt
s