Last of the Swift 6 language mode warnings #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
==========================================
+ Coverage 78.64% 78.76% +0.12%
==========================================
Files 60 60
Lines 1405 1413 +8
==========================================
+ Hits 1105 1113 +8
Misses 300 300
|
MahdiBM
reviewed
Aug 15, 2024
| @@ -40,5 +40,5 @@ let package = Package( | |||
| ] | |||
| ), | |||
| ], | |||
| swiftLanguageVersions: [.v6] | |||
| swiftLanguageModes: [.v6] | |||
There was a problem hiding this comment.
Is this necessary? what does it do to explicitly declare it? The Swift version up there is already 6.
There was a problem hiding this comment.
The change is because it's been renamed in the latest betas.
We need to set the language mode because it's separate from the tools version and opt-in given it enforces strict concurrency checking
There was a problem hiding this comment.
Alright I knew about the rename but I thought having a 6.0 Package.swift should be enough. Still need to check for myself.
ptoffy
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more retroactive conformances