Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic key addition #160

Merged
merged 10 commits into from
Apr 23, 2024
Merged

Generic key addition #160

merged 10 commits into from
Apr 23, 2024

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Apr 15, 2024

This is a breaking changes which renames the addES256, addRS384 etc. methods to more generic ones such as addECDSA and addRSA

@ptoffy ptoffy marked this pull request as ready for review April 15, 2024 09:09
@ptoffy ptoffy requested review from gwynne and 0xTim April 15, 2024 09:09
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much prefer this API - looks good! Some comments/queries

Sources/JWTKit/ECDSA/JWTKeyCollection+ECDSA.swift Outdated Show resolved Hide resolved
Sources/JWTKit/JWTError.swift Show resolved Hide resolved
Sources/JWTKit/JWTError.swift Outdated Show resolved Hide resolved
Sources/JWTKit/Utilities/CryptoSigner.swift Outdated Show resolved Hide resolved
Tests/JWTKitTests/ECDSATests.swift Outdated Show resolved Hide resolved
@ptoffy ptoffy requested a review from 0xTim April 22, 2024 13:12
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 77.57%. Comparing base (c4828b0) to head (a40b25b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   73.56%   77.57%   +4.01%     
==========================================
  Files          59       59              
  Lines        1615     1400     -215     
==========================================
- Hits         1188     1086     -102     
+ Misses        427      314     -113     
Files Coverage Δ
Sources/JWTKit/ECDSA/ECDSA.swift 85.71% <ø> (-0.29%) ⬇️
Sources/JWTKit/ECDSA/ECDSASigner.swift 90.90% <100.00%> (ø)
Sources/JWTKit/ECDSA/JWTKeyCollection+ECDSA.swift 100.00% <100.00%> (ø)
Sources/JWTKit/ECDSA/P256+CurveType.swift 100.00% <ø> (ø)
Sources/JWTKit/ECDSA/P384+CurveType.swift 100.00% <ø> (ø)
Sources/JWTKit/ECDSA/P521+CurveType.swift 100.00% <ø> (ø)
Sources/JWTKit/Utilities/CryptoSigner.swift 100.00% <100.00%> (ø)
Sources/JWTKit/X5C/X5CVerifier.swift 83.33% <100.00%> (-1.48%) ⬇️
Sources/JWTKit/HMAC/JWTKeyCollection+HMAC.swift 91.66% <90.47%> (+58.33%) ⬆️
Sources/JWTKit/JWTError.swift 44.06% <25.00%> (+20.48%) ⬆️
... and 2 more

... and 22 files with indirect coverage changes

@ptoffy ptoffy merged commit c095132 into vapor:main Apr 23, 2024
10 of 12 checks passed
@ptoffy ptoffy deleted the generic-add branch April 23, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants