fix: flush the pending requests on size change #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the combo box size is being changed, it checks the pending request for non-existing pages and flushes them, if any. Fixes vaadin/flow-components#229
web-padawan
requested changes
Oct 16, 2020
|
@tomivirkki @web-padawan I'm not able to reproduce the failure of |
yuriy-fix
approved these changes
Oct 21, 2020
tomivirkki
approved these changes
Oct 21, 2020
web-padawan
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the combo box size is being changed, it checks the pending request for non-existing pages and flushes them, if any.
Fixes vaadin/flow-components#229