🎳 Refine socks5 server UdpAssociate response behavior #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
database64128
force-pushed
the
socks-server-udp-associate-response-remote-address
branch
from
370577f to
b6f1d8c
Compare
- Previously, without specifying the server IP, the remote address in the response to a UdpAssoicate command is `127.0.0.1`, which might break UDP for non-localhost clients. - This commit changes it so that, localhost clients get responses with the corresponding loopback IP, non-localhost clients get responses with the corresponding `net.AnyIP` or `net.AnyIPv6`. - The new behavior is also consistent with many other implementations. So the compatibility is guaranteed. It also makes specifying server IP optional.
database64128
force-pushed
the
socks-server-udp-associate-response-remote-address
branch
from
b6f1d8c to
7b5b41d
Compare
mzz2017
approved these changes
Dec 16, 2020
mzz2017
added a commit
to mzz2017/glider
that referenced
this pull request
Dec 16, 2020
When server returns an any ip (0.0.0.0 or [::0]), we should use conventional ip to replace the any ip given (0.0.0.0 or [::0]). This behaviour adapts to most situations. See v2fly/v2ray-core#523
|
Thanks for your work. |
database64128
deleted the
socks-server-udp-associate-response-remote-address
branch
lucifer9
pushed a commit
to lucifer9/v2ray-core
that referenced
this pull request
Dec 18, 2020
- Previously, without specifying the server IP, the remote address in the response to a UdpAssoicate command is `127.0.0.1`, which might break UDP for non-localhost clients. - This commit changes it so that, localhost clients get responses with the corresponding loopback IP, non-localhost clients get responses with the corresponding `net.AnyIP` or `net.AnyIPv6`. - The new behavior is also consistent with many other implementations. So the compatibility is guaranteed. It also makes specifying server IP optional.
lucifer9
pushed a commit
to lucifer9/v2ray-core
that referenced
this pull request
Dec 18, 2020
- Previously, without specifying the server IP, the remote address in the response to a UdpAssoicate command is `127.0.0.1`, which might break UDP for non-localhost clients. - This commit changes it so that, localhost clients get responses with the corresponding loopback IP, non-localhost clients get responses with the corresponding `net.AnyIP` or `net.AnyIPv6`. - The new behavior is also consistent with many other implementations. So the compatibility is guaranteed. It also makes specifying server IP optional.
nadoo
pushed a commit
to nadoo/glider
that referenced
this pull request
Feb 7, 2021
* fix(socks5): should not dial returned bind addr directly When server returns an any ip (0.0.0.0 or [::0]), we should use conventional ip to replace the any ip given (0.0.0.0 or [::0]). This behaviour adapts to most situations. See v2fly/v2ray-core#523 * fix: splithostport
database64128
added a commit
to v2fly/v2fly-github-io
that referenced
this pull request
Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
127.0.0.1, which might break UDP for non-localhost clients.net.AnyIPornet.AnyIPv6.