-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SpreadAllocate and PackedAllocate traits and impls #978
Conversation
Note: We cannot add allocate_spread to SpreadLayout trait since certain types (such as Result<T, E>) that implement SpreadLayout cannot implement SpreadAllocate; OR certain types can trivially implement SpreadLayout but are constraint with respect to SpreadAllocate and vice versa.
Codecov Report
@@ Coverage Diff @@
## master #978 +/- ##
===========================================
- Coverage 79.16% 62.74% -16.43%
===========================================
Files 244 244
Lines 9149 9160 +11
===========================================
- Hits 7243 5747 -1496
- Misses 1906 3413 +1507
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm!
We should definitely add tests in a follow-up though! Could you create a follow-up issue for that?
Implements #961.