Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpreadAllocate and PackedAllocate traits and impls #978

Merged
merged 23 commits into from
Oct 23, 2021

Conversation

Robbepop
Copy link
Collaborator

Implements #961.

@Robbepop Robbepop marked this pull request as draft October 22, 2021 16:08
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2021

Codecov Report

Merging #978 (093e580) into master (4534c4a) will decrease coverage by 16.42%.
The diff coverage is 47.82%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #978       +/-   ##
===========================================
- Coverage   79.16%   62.74%   -16.43%     
===========================================
  Files         244      244               
  Lines        9149     9160       +11     
===========================================
- Hits         7243     5747     -1496     
- Misses       1906     3413     +1507     
Impacted Files Coverage Δ
crates/storage/src/collections/stash/mod.rs 97.43% <ø> (ø)
crates/storage/src/collections/stash/storage.rs 60.97% <0.00%> (-4.82%) ⬇️
crates/storage/src/collections/vec/storage.rs 64.70% <ø> (ø)
crates/storage/src/lazy/cache_cell.rs 100.00% <ø> (ø)
crates/storage/src/lazy/entry.rs 94.73% <ø> (ø)
crates/storage/src/lazy/lazy_array.rs 96.22% <ø> (ø)
crates/storage/src/lazy/lazy_hmap.rs 93.23% <ø> (ø)
crates/storage/src/lazy/lazy_imap.rs 92.94% <ø> (ø)
crates/storage/src/lazy/mod.rs 93.54% <ø> (ø)
crates/storage/src/memory.rs 100.00% <ø> (ø)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4534c4a...093e580. Read the comment docs.

@Robbepop Robbepop marked this pull request as ready for review October 23, 2021 08:21
Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

We should definitely add tests in a follow-up though! Could you create a follow-up issue for that?

@Robbepop Robbepop merged commit 4b5d91a into master Oct 23, 2021
@Robbepop Robbepop deleted the robin-implement-spread-allocate branch October 23, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants