Add fuzz tests for StorageVec::binary_search*
#867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
force-pushed
the
cmichi-add-fuzz-tests-for-vec-binary-search
branch
from
521582a to
f5a7344
Compare
We found that bugs are usually already found with low numbers.
HCastano
approved these changes
Jul 20, 2021
| @@ -415,7 +415,7 @@ fuzz-tests: | |||
| <<: *test-refs | |||
| variables: | |||
| # The QUICKCHECK_TESTS default is 100 | |||
| QUICKCHECK_TESTS: 20000 | |||
| QUICKCHECK_TESTS: 5000 | |||
There was a problem hiding this comment.
Why is this being reduced? What kind of time savings are we looking at?
There was a problem hiding this comment.
See the extended commit message. Current duration is ~15 minutes for this stage, I'd like to see how this reduces with this lower number.
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #836.