Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not generate metadata if compile_as_dependency is true #811

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Jun 8, 2021

Extracted change from this PR:
#810

@Robbepop
Copy link
Collaborator

Robbepop commented Jun 9, 2021

CI is apparently not happy with this. I don't yet know why but it might not be related to this PR in particular.

@xgreenx
Copy link
Collaborator Author

xgreenx commented Jun 9, 2021

CI is apparently not happy with this. I don't yet know why but it might not be related to this PR in particular.

CI in master fails. This PR must fix that: #812

@Robbepop
Copy link
Collaborator

Robbepop commented Jun 9, 2021

CI is apparently not happy with this. I don't yet know why but it might not be related to this PR in particular.

CI in master fails. This PR must fix that: #812

merged that one. please rebase.

@xgreenx xgreenx force-pushed the bugfix/not-generate-metadata-when-dependency branch from 59a99b3 to 37b2947 Compare June 9, 2021 14:22
Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to point out that this PR just unifies what we are already doing elsewhere.

@Robbepop Robbepop merged commit e148656 into use-ink:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants