-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace array impls with const generics #754
Conversation
Thank you for the PR @austinabell !
We won't need to feature flag this since we are on Rust nightly which includes (by definition) the latest Rust 1.51 where this feature has already been stabilized. |
The CI is currently unhappy due to examples needing to be updated with the updated SCALE codec crate. However, I'd instead love to see support for this in SCALE codec crate prior to merging this PR. Would be cool if you want to spearhead this! |
Ah my bad, I thought this was assumed, I should have put that comment in the description. Yeah I'm leaving this PR in draft state until paritytech/parity-scale-codec#261 comes in, then I'll update the reference here and open up the PR. I was just too lazy to patch all examples since it was a temporary check to make sure everything compiles. Edit: Also have no rush to release the scale codec, happy to leave this sitting until it does. I don't need this change for anything, just did it for fun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Requires update to cargo-contract
template.
That change is merged :) Anything else needed? |
Does not look like it to me tbh /~https://github.com/paritytech/cargo-contract/blob/master/templates/new/_Cargo.toml#L14 |
oh ooops lol, the different naming threw me off there. That's a dumb mistake, I'll update that now edit: PR link - use-ink/cargo-contract#252 |
Thanks a lot for your PR @austinabell ! :) |
Closes #752
Not sure if you would like it under a feature to not be a breaking change (if msrv is important), but happy to make that change if so :D