Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for 'caller_is_root' #2332

Merged
merged 13 commits into from
Dec 5, 2024

Conversation

olahfemi
Copy link
Contributor

@olahfemi olahfemi commented Dec 3, 2024

Summary

Closes #_

  • n | Does it introduce breaking changes?
  • n | Is it dependant on the specific version of cargo-contract or pallet-contracts?

This PR aims to add support for the caller_is_root function as requested by this issue

Description

Since the caller_is_root function is similar to caller_is_origin, I looked for places where the latter was implemented and did the same for the former.

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@olahfemi
Copy link
Contributor Author

olahfemi commented Dec 3, 2024

@cmichi Re: your comment:
I couldn't find SHA id of the commit that made many of the unrelated changes in my local log, so I created a new PR.

@cmichi
Copy link
Collaborator

cmichi commented Dec 4, 2024

@olahfemi There are some CI errors due to an unclosed delimiter. You can check this guide on how to run what the CI does locally.

@olahfemi
Copy link
Contributor Author

olahfemi commented Dec 4, 2024

@olahfemi There are some CI errors due to an unclosed delimiter. You can check this guide on how to run what the CI does locally.

@cmichi, the unclosed delimiter has been fixed, and many of the local verification steps are passing now.

The failed steps weren't as a result of my changes. What do you want us to do about that?

Also, if my latest commit seems to have changed many unrelated files, it's because of the master merge and local verification.

@cmichi
Copy link
Collaborator

cmichi commented Dec 4, 2024

It's likely that you are using a different nightlyv version locally to execute the cargo +nightly fmt --all. Could you try

rustup update nightly
cargo +nightly fmt --all

And push the changes?

@cmichi
Copy link
Collaborator

cmichi commented Dec 4, 2024

Alternatively: can you allow me to edit your PR as described here?

@cmichi cmichi mentioned this pull request Dec 4, 2024
7 tasks
@olahfemi
Copy link
Contributor Author

olahfemi commented Dec 5, 2024

I've updated the nightly version, reran fmt and pushed the changes. Also, maintainers have edit access to the PR, so you can make edits if necessary.

@cmichi cmichi merged commit 9066a03 into use-ink:master Dec 5, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants