ERC-721: Clear approval in burn()
#2099
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cargo-contract
orpallet-contracts
?burn()
should probably clear token approval for the token. Otherwise, the following sequence of events is possible:Mainly the concern would be that steps 1-3 could be performed by someone frontrunning, i.e. they see a pending transaction for step 4 in the mempool, and perform steps 1-3 first.
This PR updates the
burn
function to also clear the token approval, and adds a test for the described scenario above (with step 5 failing).Checklist before requesting a review
CHANGELOG.md