ERC-721 example: fix panic re: approve_for
with nonexistent token
#2092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cargo-contract
orpallet-contracts
?In the current ERC-721 example used in integration tests (which is the source of the erc-721 example in ink-examples), the
approve_for
function will panic with the text '"Error with AccountId"' if the token id does not exist. This PR changes the function to return anError::TokenNotFound
in this case instead.I am using Prusti to verify correctness properties of the contract; the presence of this bug prevents the verification of a "panic-freedom" property.
Description
Updated the logic and added a corresponding test.
Checklist before requesting a review
CHANGELOG.md