Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of the Cargo hack #2007

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Get rid of the Cargo hack #2007

merged 2 commits into from
Nov 29, 2023

Conversation

pmikolajczyk41
Copy link
Member

Summary

Closes #1929

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependant on the specific version of cargo-contract or pallet-contracts?

Description

Get rid of annoying warnings during cargo actions about unused attribute. The problem is well described in the issue.

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@pmikolajczyk41 pmikolajczyk41 marked this pull request as draft November 28, 2023 15:51
@pmikolajczyk41
Copy link
Member Author

we need to rely on the newest parity-scale-codec version that would contain Andrew's dependency bump

@ascjones
Copy link
Collaborator

we need to rely on the newest parity-scale-codec version that would contain Andrew's dependency bump

https://crates.io/crates/parity-scale-codec/3.6.9

ascjones
ascjones approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will be happy to see the back of these warnings 🎉

@pmikolajczyk41 pmikolajczyk41 marked this pull request as ready for review November 29, 2023 11:21
@ascjones ascjones merged commit bc6045b into master Nov 29, 2023
19 of 21 checks passed
@ascjones ascjones deleted the cargo-warning branch November 29, 2023 15:56
@ascjones ascjones mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

@SkymanOne SkymanOne Awaiting requested review from SkymanOne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of the cargo warning about unused manifest key
2 participants
@pmikolajczyk41 @ascjones