ink-e2e Test Failures in substrate-contracts-node (v0.27.0) due to Unsupported --ws-port Argument #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was doing it from the v4.1.0 tag, and didn't know where to merge, please @SkymanOne can you help me with that? |
ascjones
approved these changes
Jul 19, 2023
ascjones
added a commit
that referenced
this pull request
Aug 23, 2023
…1884) * Manual backport of #1883: Use `contract-build` `3.2.0` * ink-e2e Test Failures in substrate-contracts-node (v0.27.0) due to Unsupported --ws-port Argument (#1850) * Update ink-e2e to the latest substrate-contracts-node * Apply rust-fmt * Change logging, to be up-to-date with master branch * Apply rustfmt-nightly (cherry picked from commit 6d7810e) * Remove --ws-port arg * Update substrate deps * Manual backports of #1795 and #1855 to update subxt * Update subxt in example * Backport: fix e2e test, account for contract initial free balance (#1777) * Use latest CI image * 🦖 fix spellcheck for new version, add words to dict (#1836) * Fix call-runtime tests * enable call-runtime tests * ui tests * `[ink_e2e]` update `Determinism` enum to match Substrate definition (#1781) * `[ink_e2e]` update `Determinism` enum to match Substrate definition * fmt * Fix multi_contract_caller example for new deposit behaviour * Reenable examples-test step * Fix integration test * Remove riscv +stable * Fix riscv build --------- Co-authored-by: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>
goastler
pushed a commit
to prosopo/ink_sr25519
that referenced
this pull request
Aug 31, 2023
…se-ink#1884) * Manual backport of use-ink#1883: Use `contract-build` `3.2.0` * ink-e2e Test Failures in substrate-contracts-node (v0.27.0) due to Unsupported --ws-port Argument (use-ink#1850) * Update ink-e2e to the latest substrate-contracts-node * Apply rust-fmt * Change logging, to be up-to-date with master branch * Apply rustfmt-nightly (cherry picked from commit 6d7810e) * Remove --ws-port arg * Update substrate deps * Manual backports of use-ink#1795 and use-ink#1855 to update subxt * Update subxt in example * Backport: fix e2e test, account for contract initial free balance (use-ink#1777) * Use latest CI image * 🦖 fix spellcheck for new version, add words to dict (use-ink#1836) * Fix call-runtime tests * enable call-runtime tests * ui tests * `[ink_e2e]` update `Determinism` enum to match Substrate definition (use-ink#1781) * `[ink_e2e]` update `Determinism` enum to match Substrate definition * fmt * Fix multi_contract_caller example for new deposit behaviour * Reenable examples-test step * Fix integration test * Remove riscv +stable * Fix riscv build --------- Co-authored-by: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>
goastler
pushed a commit
to prosopo/ink_sr25519
that referenced
this pull request
Aug 31, 2023
…se-ink#1884) * Manual backport of use-ink#1883: Use `contract-build` `3.2.0` * ink-e2e Test Failures in substrate-contracts-node (v0.27.0) due to Unsupported --ws-port Argument (use-ink#1850) * Update ink-e2e to the latest substrate-contracts-node * Apply rust-fmt * Change logging, to be up-to-date with master branch * Apply rustfmt-nightly (cherry picked from commit 6d7810e) * Remove --ws-port arg * Update substrate deps * Manual backports of use-ink#1795 and use-ink#1855 to update subxt * Update subxt in example * Backport: fix e2e test, account for contract initial free balance (use-ink#1777) * Use latest CI image * 🦖 fix spellcheck for new version, add words to dict (use-ink#1836) * Fix call-runtime tests * enable call-runtime tests * ui tests * `[ink_e2e]` update `Determinism` enum to match Substrate definition (use-ink#1781) * `[ink_e2e]` update `Determinism` enum to match Substrate definition * fmt * Fix multi_contract_caller example for new deposit behaviour * Reenable examples-test step * Fix integration test * Remove riscv +stable * Fix riscv build --------- Co-authored-by: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR addresses an issue with the latest version of substrate-contracts-node (v0.27.0) wherein the --ws-port argument is not being supported, causing the end-to-end tests to fail. The specific error message produced is: "We should find a port before the reader ends".